Suppress too-many-ancestors for ModelViewSets #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
suggested changes
Jul 7, 2022
There was a problem hiding this comment.
Overall looks good but needs tests.
- see
extras_requireinsetup.pyand add django-rest-framework as dependency - See the
pylint_django/tests/input/external_*files and based on the same pattern add a ModelViewSet definition which we expect to not trigger too-may-ancestors error messages.
|
Thanks for the pointers, just added a test. I saw that the other drf-related test was marked as skipped because of the missing dependency. Do you know how to re-enable it? |
carlio
force-pushed
the
master
branch
5 times, most recently
from
aa6c7ee
to
054b49a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.