Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove false positive error of missing member in TextChoices tuples #298

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 23 additions & 0 deletions pylint_django/tests/input/func_noerror_model_enum.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
"""
Test that django TextChoices does not raise a warning due to .label and .value methods
"""
# pylint: disable=missing-docstring,too-few-public-methods

from django.db import models


class SomeTextChoices(models.TextChoices):
CHOICE_A = ("choice_a", "Choice A")
CHOICE_B = ("choice_b", "Choice B")
CHOICE_C = ("choice_c", "Choice C")


class SomeClass():
choice_values = [
SomeTextChoices.CHOICE_A.value,
SomeTextChoices.CHOICE_B.value,
]
choice_labels = [
SomeTextChoices.CHOICE_B.label,
SomeTextChoices.CHOICE_C.label,
]
4 changes: 2 additions & 2 deletions pylint_django/transforms/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@

import astroid

from pylint_django.transforms import fields
from pylint_django.transforms import fields, text_choices

fields.add_transforms(astroid.MANAGER)

text_choices.add_transforms(astroid.MANAGER)

def _add_transform(package_name):
def fake_module_builder():
Expand Down
70 changes: 70 additions & 0 deletions pylint_django/transforms/text_choices.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
from astroid import MANAGER, scoped_nodes, nodes, inference_tip

from pylint_django import utils

class_names = set()

def is_tuple_in_text_choices(node):
# file_name = node.root().file
# if file_name not in file_names:
# file_names.update({file_name})
# import ipdb; ipdb.set_trace()
# else:
# return False

if not (isinstance(node.parent, nodes.Assign)
or isinstance(node.parent, nodes.FunctionDef)) :
return False
if not isinstance(node.parent.parent, nodes.ClassDef):
return False
if "TextChoices" in [i.name for i in node.parent.parent.bases]:
import ipdb; ipdb.set_trace()

class_name = node.parent.parent.name
if class_name not in class_names:
class_names.update({class_name})
# import ipdb; ipdb.set_trace()
else:
return False

# if node.parent.parent.name == "SomeTextChoices":
# import ipdb; ipdb.set_trace()
# else:
# return False

# if node.parent.parent.parent.name in ["TextChoices", "SomeClass", "ChoicesMeta", "TextChoices"]:
# import ipdb; ipdb.set_trace()
# else:
# return False

# if node.root().file.endswith("enums.py"):
# import ipdb; ipdb.set_trace()
# else:
# return False

# try:
# if node.root().file.endswith("model_enum.py"):
# import ipdb; ipdb.set_trace()
# except:
# import ipdb; ipdb.set_trace()
# if (node.parent.parent.name != "LazyObject"
# and node.parent.parent.parent.name != "django.db.models.expressions"
# and node.parent.parent.parent.name != "django.db.models.fields"):
# import ipdb; ipdb.set_trace()

if isinstance(node.func, nodes.Attribute):
attr = node.func.attrname
elif isinstance(node.func, nodes.Name):
attr = node.func.name
else:
return False
return True


def infer_key_classes(node, context=None):
pass


def add_transforms(manager):
manager.register_transform(nodes.Call, inference_tip(infer_key_classes),
is_tuple_in_text_choices)