Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Django settings handling #287

Merged
merged 8 commits into from
Aug 28, 2020

Commits on Aug 24, 2020

  1. Moved the Django foreignkey field into a separate checker to enable t…

    …he `open()` pre-configuration. This allows the django settings module to be set from a command-line option or .pylintrc option as well as an environment variable (refs #286). This commit also uses default Django settings if none are specified, raising an error to the user to inform them that it is better to set it explicitly, but avoiding the need to raise a Fatal or RuntimeError if Django is not configured (refs #277 and #243)
    carlio committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    36fc49f View commit details
    Browse the repository at this point in the history
  2. Removing the "Django not configured" check from tox sanity/basic chec…

    …king - alternative is to manually supply a basic django settings file which seems like it would clog up the repo more than one single disable flag in the tox file
    carlio committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    26f3af3 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Configuration menu
    Copy the full SHA
    21487b4 View commit details
    Browse the repository at this point in the history
  2. Pylint now depends on isort and the current version of isort has a bi…

    …nary dependancy on clikit, so either we have to pin isort to an earlier version or prevent checking that pylint-django can be installed with --no-binary (since, presumably, isort and therefore pylint now require binary package dependencies)
    carlio committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    c7730fa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    08ad9de View commit details
    Browse the repository at this point in the history
  4. Adding information to the README about hwo to configure Django settin…

    …gs and the reason for doing so
    carlio committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    f7b556b View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Small typo fix

    carlio committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    aa7f80b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7721691 View commit details
    Browse the repository at this point in the history