Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ForeignKey String References #272

Merged
merged 12 commits into from Jul 21, 2020
Merged

Handle ForeignKey String References #272

merged 12 commits into from Jul 21, 2020

Conversation

alejandro-angulo
Copy link
Contributor

@alejandro-angulo alejandro-angulo commented Jul 12, 2020 •
edited

Possible solution to #243 . This change leverages Django's model name resolution to handle ForeignKey string references.

@coveralls
Copy link

coveralls commented Jul 12, 2020 •
edited

Pull Request Test Coverage Report for Build 1133

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 88.553%
Totals Coverage Status
Change from base Build 1115: 0.2%
Covered Lines: 673
Relevant Lines: 760
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1117

  • 18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 88.657%
Totals Coverage Status
Change from base Build 1115: 0.3%
Covered Lines: 680
Relevant Lines: 767
💛 - Coveralls

atodorov
atodorov suggested changes Jul 15, 2020
View reviewed changes
README.rst Outdated Show resolved Hide resolved
pylint_django/transforms/foreignkey.py Outdated Show resolved Hide resolved
pylint_django/tests/test_app/apps.py Outdated Show resolved Hide resolved
pylint_django/tests/test_func.py Show resolved Hide resolved
pylint_django/transforms/foreignkey.py Outdated Show resolved Hide resolved
atodorov
atodorov suggested changes Jul 20, 2020
View reviewed changes
pylint_django/tests/conftest.py Outdated Show resolved Hide resolved
pylint_django/transforms/foreignkey.py Show resolved Hide resolved
pylint_django/transforms/foreignkey.py Show resolved Hide resolved
pylint_django/transforms/foreignkey.py Outdated Show resolved Hide resolved
pylint_django/tests/input/func_noerror_string_foreignkey.py Show resolved Hide resolved
@alejandro-angulo
Undo making django imports top-level
19e601b 
Making the django imports top-level imports caused the build to break
(django not installed check failed).
@atodorov atodorov merged commit ec4f005 into pylint-dev:master Jul 21, 2020
@ajhodges
Copy link

https://github.com/PyCQA/pylint-django#known-issues

I think the Readme can probably be updated now 👍👍

atodorov added a commit that referenced this pull request Jul 22, 2020
@atodorov
Update for models referenced as strings. Refs #272
4371836
atodorov added a commit that referenced this pull request Jul 22, 2020
@atodorov
Update for models referenced as strings. Refs #272
a8a8302
@515hikaru
Copy link

@alejandro-angulo I was just in trouble facing this problem. Thank you for fixing it!

@alejandro-angulo alejandro-angulo deleted the handle-string-fk branch July 26, 2020 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atodorov atodorov Awaiting requested review from atodorov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alejandro-angulo @coveralls @ajhodges @515hikaru @atodorov