Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix too broad suppression of unused-argument warnings #251

Merged
merged 3 commits into from Nov 4, 2019
Merged

Fix too broad suppression of unused-argument warnings #251

merged 3 commits into from Nov 4, 2019

Commits on Nov 3, 2019

  1. Pass arguments of test.sh to test_func/pytest 

    Previously you had to modify scripts/test.sh to add command line
arguments to pytest. Now you can add them directly when calling test.sh.

This is useful if you, for example, want to filter the executed tests
using `-k`.
    @psrb
    psrb committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    99e6ecb View commit details
    Browse the repository at this point in the history

  2. Load pylint plugin configuration in test case 

    When running the tests the plugin was loaded but its
`load_configuration` function was not called. The function needs to be
called so changes to config entries can be tested.
    @psrb
    psrb committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    ece701a View commit details
    Browse the repository at this point in the history

  3. Ignore unused-argument warning for request arguments (Fixes pylint-de… 

    …v#249)

The previous implementation (result of pylint-dev#155) of disabling the
unused-argument warning for functions/methods having an argument named
`request` was to broad. As soon as a function/method contains a
`request` argument no unused-argument warning will be issued for this
function anymore, even though some other arguments are unused!

This commit monkey patches `VariablesChecker._is_ignored_named` to
specifically suppress the generation of unused-argument warnings for
arguments named `request`.
This way unused-argument warnings will still be issued for every other
unused argument of the function/method.
    @psrb
    psrb committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    a7cb1e1 View commit details
    Browse the repository at this point in the history