Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump astroid to 3.0.0, update changelog #2303

Merged
merged 6 commits into from Sep 26, 2023
Merged

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Sep 25, 2023

@Pierre-Sassoulas Pierre-Sassoulas added Work in progress Maintenance Discussion or action around maintaining astroid or the dev workflow labels Sep 25, 2023
@Pierre-Sassoulas Pierre-Sassoulas marked this pull request as draft September 25, 2023 07:39
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2303 (0ea6d86) into main (1f0f2f8) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2303   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files          94       94           
  Lines       11056    11056           
=======================================
  Hits        10266    10266           
  Misses        790      790           
Flag Coverage Δ
linux 92.66% <100.00%> (ø)
pypy 91.00% <100.00%> (ø)
windows 92.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
astroid/__pkginfo__.py 100.00% <100.00%> (ø)

@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.0 milestone Sep 25, 2023
@jacobtylerwalls
Copy link
Member

We should consider reverting #1873 as part of this. It was a good idea at the time, but we did a good job with the changelog fragments. I don't know what other content we would put in the upgrade guide.

@jacobtylerwalls
Copy link
Member

Use the global inference cache when inferring, even without an explicit
InferenceContext. This is a significant performance improvement given how
often methods default to None for the context argument. (Linting astroid
itself now takes ~5% less time on Python 3.12; other projects requiring more
complex inference calculations will see greater speedups.)

Should we move this near the top?

@Pierre-Sassoulas
Copy link
Member Author

Sorry, I had to put the date in. If it's ready today then.. I know the date 😄

@jacobtylerwalls
Copy link
Member

@Pierre-Sassoulas do you want to wait a day or two to give @mbyrnepr2 a chance to look at #2305?

@Pierre-Sassoulas
Copy link
Member Author

Yeah, let's release a last 2.x maintenance version of astroid.

@Pierre-Sassoulas Pierre-Sassoulas added the Blocked 🚧 A PR or issue blocked by another PR or issue label Sep 25, 2023
github-actions bot and others added 2 commits September 26, 2023 08:18
Fix a regression in 2.15.7 for ``unsubscriptable-object``.

Raise an `InferenceError` when there is a `SyntaxError` due to an invalid `TypeVar` name.
This reverts commit 89dfb48.

Closes #2305
Closes pylint-dev/pylint#9069

(cherry picked from commit 1f0f2f8)

Co-authored-by: Mark Byrne <31762852+mbyrnepr2@users.noreply.github.com>
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for a rebase

@Pierre-Sassoulas
Copy link
Member Author

This will need a merge commit because I also merged the maintenance branch at the same time (squash or rebase won't do).

@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 A PR or issue blocked by another PR or issue label Sep 26, 2023
@Pierre-Sassoulas Pierre-Sassoulas merged commit 0883b04 into main Sep 26, 2023
20 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the release-branch-3.0.0 branch September 26, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment