Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit] Trying out black 23.1a1 #1909

Merged
merged 3 commits into from Dec 27, 2022
Merged

Conversation

Pierre-Sassoulas
Copy link
Member

Description

Type of Changes

Type
🔨 Refactoring

Related Issue

See psf/black#3407 / https://ichard26.github.io/blog/2022/12/black-23.1a1/

@Pierre-Sassoulas Pierre-Sassoulas added the dependency Related to dependencies of the project label Dec 21, 2022
@coveralls
Copy link

coveralls commented Dec 21, 2022

Pull Request Test Coverage Report for Build 3786151133

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 92.32%

Files with Coverage Reduction New Missed Lines %
astroid/brain/brain_namedtuple_enum.py 1 93.41%
Totals Coverage Status
Change from base Build 3786038399: 0.0%
Covered Lines: 9929
Relevant Lines: 10755

💛 - Coveralls

DanielNoord
DanielNoord previously approved these changes Dec 26, 2022
@DanielNoord DanielNoord dismissed their stale review December 26, 2022 23:10

Last change doesn't look good

@@ -6498,7 +6497,9 @@ def __init__(self, *args, **kwargs):
assert inferred is util.Uninferable


def test_inferring_properties_multiple_time_does_not_mutate_locals_multiple_times() -> None:
def test_inferring_properties_multiple_time_does_not_mutate_locals_multiple_times() -> (
None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels very weird?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black is trying to make the line length smaller by any mean necessary :)

tests/unittest_inference.py Outdated Show resolved Hide resolved
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
@Pierre-Sassoulas Pierre-Sassoulas merged commit 380e886 into main Dec 27, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the testing-black-alpha branch December 27, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Related to dependencies of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants