Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the hashlib brain hash.digest & hash.hexdigest methods. #1827

Merged
merged 2 commits into from Oct 15, 2022
Merged

Update the hashlib brain hash.digest & hash.hexdigest methods. #1827

merged 2 commits into from Oct 15, 2022

Conversation

mbyrnepr2
Copy link
Member

Add the length parameter to hash.digest & hash.hexdigest in the hashlib in the case of the shake_128 and shake_256 algorithms .

hashlib Documentation

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Type of Changes

Type
✓ 🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Related Issue

Refs pylint-dev/pylint#4039

@coveralls
Copy link

coveralls commented Oct 10, 2022 •
edited

Pull Request Test Coverage Report for Build 3222483466

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 92.298%
Totals Coverage Status
Change from base Build 3221346113: 0.001%
Covered Lines: 9862
Relevant Lines: 10685
💛 - Coveralls

@mbyrnepr2 mbyrnepr2 added Bug 🪳 Brain 🧠 Needs a brain tip labels Oct 10, 2022
@mbyrnepr2 mbyrnepr2 self-assigned this Oct 10, 2022
@mbyrnepr2 mbyrnepr2 modified the milestone: 2.13.0 Oct 10, 2022
@mbyrnepr2 mbyrnepr2 added this to the 2.12.12 milestone Oct 10, 2022
@mbyrnepr2 mbyrnepr2 merged commit 2bdcd08 into pylint-dev:main Oct 15, 2022
@mbyrnepr2 mbyrnepr2 deleted the pylint_issue_4039 branch October 15, 2022 08:33
Pierre-Sassoulas pushed a commit that referenced this pull request Oct 19, 2022
@mbyrnepr2 @Pierre-Sassoulas
Update the hashlib brain hash.digest & hash.hexdigest met…
6b19565 
…hods. (#1827)

* Add the ``length`` parameter to ``hash.digest`` & ``hash.hexdigest`` in the ``hashlib`` brain.

* Move content in Changelog to a different section.

Refs pylint-dev/pylint#4039
Pierre-Sassoulas pushed a commit that referenced this pull request Oct 19, 2022
@mbyrnepr2 @Pierre-Sassoulas
Update the hashlib brain hash.digest & hash.hexdigest met…
fccbc97 
…hods. (#1827)

* Add the ``length`` parameter to ``hash.digest`` & ``hash.hexdigest`` in the ``hashlib`` brain.

* Move content in Changelog to a different section.

Refs pylint-dev/pylint#4039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees

@mbyrnepr2 mbyrnepr2

Labels
Brain 🧠 Needs a brain tip Bug 🪳
Projects
None yet
Milestone
2.12.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mbyrnepr2 @coveralls @DanielNoord @Pierre-Sassoulas