Fix crash in dataclass brain
#1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3001624485
💛 - Coveralls |
This was referenced Sep 6, 2022
Pierre-Sassoulas
approved these changes
Sep 6, 2022
Pierre-Sassoulas
approved these changes
Sep 6, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Sep 6, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Sep 6, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Closes pylint-dev/pylint#7422
Type of Changes
I also fixed the typing in this module. This bug would have been easily been prevented if the module didn't raise 40+ warnings so the actual warning that would fix this was drowned out.
Again, sorry guys...
Refs. #1768 #1764