Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash while obtaining object_type() of an Unknown node #1547

Merged
merged 2 commits into from May 7, 2022
Merged

Fix crash while obtaining object_type() of an Unknown node #1547

merged 2 commits into from May 7, 2022

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented May 7, 2022 •
edited

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

Refs pylint-dev/pylint#6539. We might be able to just close the issue, as the test will look identical in pylint.

@jacobtylerwalls jacobtylerwalls added this to the 2.11.5 milestone May 7, 2022
@coveralls
Copy link

coveralls commented May 7, 2022 •
edited

Pull Request Test Coverage Report for Build 2287062474

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 91.737%
Totals Coverage Status
Change from base Build 2285557844: 0.002%
Covered Lines: 9159
Relevant Lines: 9984
💛 - Coveralls

@jacobtylerwalls jacobtylerwalls added pylint-tested PRs that don't cause major regressions with pylint needs-backport labels May 7, 2022
Pierre-Sassoulas
Pierre-Sassoulas approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jacobtylerwalls
jacobtylerwalls commented May 7, 2022
View reviewed changes
ChangeLog Outdated Show resolved Hide resolved
@jacobtylerwalls jacobtylerwalls merged commit 95403ff into pylint-dev:main May 7, 2022
@jacobtylerwalls jacobtylerwalls deleted the unknown-proxied branch May 7, 2022 18:38
@jacobtylerwalls jacobtylerwalls mentioned this pull request May 9, 2022
Merged
Pierre-Sassoulas pushed a commit that referenced this pull request May 9, 2022
@jacobtylerwalls @Pierre-Sassoulas
Fix crash while obtaining object_type() of an Unknown node (#1547)
140aaca
Pierre-Sassoulas pushed a commit that referenced this pull request May 9, 2022
@jacobtylerwalls @Pierre-Sassoulas
Fix crash while obtaining object_type() of an Unknown node (#1547)
fb553fd
@jacobtylerwalls jacobtylerwalls mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
pylint-tested PRs that don't cause major regressions with pylint
Projects
None yet
Milestone
2.11.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobtylerwalls @coveralls @Pierre-Sassoulas