Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InferenceContext to ClassModel #1257

Merged
merged 1 commit into from Nov 19, 2021
Merged

Add InferenceContext to ClassModel #1257

merged 1 commit into from Nov 19, 2021

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Nov 18, 2021 •
edited

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

This fixes the issue reported here pylint-dev/pylint#4982

I could also add the InferenceContext on ObjectModel, but for now I think this is fine.

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

pylint-dev/pylint#4982

@DanielNoord DanielNoord added this to the 2.8.6 milestone Nov 18, 2021
@DanielNoord DanielNoord mentioned this pull request Nov 18, 2021
Merged
4 tasks
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 96ca4dc into pylint-dev:main Nov 19, 2021
@DanielNoord DanielNoord deleted the crash branch November 19, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanielNoord @Pierre-Sassoulas