Add flake8 typing import to the pre-commit configuration #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
Maintenance
Pierre-Sassoulas
force-pushed
the
add-flake8-typing-import
branch
from
ace772b
to
e0323e7
Compare
Think I mentioned it somewhere: |
Yes you did 😄 It's an old MR that was written before you did and got "lost" because I wanted to fix another issue that wasn't strictly necessary to fix (#1271) |
tushar-deepsource
pushed a commit
to tushar-deepsource/astroid
that referenced
this pull request
Dec 20, 2021
…1240) Relates to pylint-dev#1239 Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a typing check to pre-commit, also apply flake8 to more files.
Type of Changes
Related Issue
Should have helped for #1239, but did not.