Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary disable from pylintrc #1223

Merged
merged 2 commits into from Oct 24, 2021
Merged

Remove unnecessary disable from pylintrc #1223

merged 2 commits into from Oct 24, 2021

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

With the refractor of nodes the too-many-lines option can be removed!

Type of Changes

Type
✓ ✨ New feature
✓ 🔨 Refactoring

Related Issue

Closes #465

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Oct 24, 2021
@DanielNoord DanielNoord added this to the 2.8.4 milestone Oct 24, 2021
@DanielNoord
Copy link
Collaborator Author

Uh. I don't know why I thought there was a 2.11.2 release 😆

@DanielNoord DanielNoord changed the title Update pylint to 2.11.2 and update pylintrc Remove unnecessary disable from pylintrc Oct 24, 2021
@Pierre-Sassoulas
Copy link
Member

We renamed 2.11.2 to 2.12, and now we really need to release it see pylint-dev/pylint#5065 (comment) 😄

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Oct 24, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Cleaning up issue is always very valuable. Maybe one day it'll be manageable again 😄

@DanielNoord
Copy link
Collaborator Author

Ah yeah, that explains the confusion. I wondered why I 2.11.2 seemed so familiar.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 38849d8 into pylint-dev:main Oct 24, 2021
@DanielNoord DanielNoord deleted the pylint branch October 24, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
2.8.4
Development

Successfully merging this pull request may close these issues.

node_classes.py has too many lines
2 participants
@DanielNoord @Pierre-Sassoulas