Add Arguments typing to Lambda & FunctionDef
#1174
Conversation
|
|
||
| :type: Arguments or list | ||
| """ | ||
| self.args: Arguments |
There was a problem hiding this comment.
At some point we should probably enforce that postinit is actually called. Otherwise self.args might not be set when accessed. Task for another time. (It's somewhere on my long list.)
There was a problem hiding this comment.
This is already note the case.. Of the two places creating a FunctioDef only one does this. Oh well... 😄
There was a problem hiding this comment.
Which one do you mean? raw_building, objectmodel, and rebuilder are fine. Am I missing something? I didn't notice any errors while running the tests either.
There was a problem hiding this comment.
The postinit is called on Arguments, but the FunctionDef.postinit method is never called.
There was a problem hiding this comment.
At least func.args is still assigned. So it won't break (just yet).
There was a problem hiding this comment.
Something to fix in the future I guess. Seems like the Lambda and FunctionDef class could use a refactor anyway.
There was a problem hiding this comment.
Someday... Too many other things open at the moment 😪
There was a problem hiding this comment.
Someday... Too many other things open at the moment
Yeah let's finish up 2.11 first and the typing MR first. The code is getting better little by little and that's great, but let's merge what we did already. There are a lot of changes in those, and conflicts could become a problem.
There was a problem hiding this comment.
I expect to have pylint-dev/pylint#4980 ready for review in 5-10 minutes!
cdce8p
added
Maintenance
Steps
Description
This should fix some of the problems we were having with
args.???in #1170.See this comment #1170 (comment)
This should make it possible to remove the disable's added in that PR.
/CC @cdce8p
Type of Changes
Related Issue