Don't calculate slots when MRO parsing fails. #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Probably the astroid fix we need for pylint-dev/pylint#4688, thank you ! |
These two issues are orthogonal as per my understanding. Thanks! |
Pierre-Sassoulas
requested changes
Jul 9, 2021
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Pierre-Sassoulas
approved these changes
Jul 10, 2021
Pierre-Sassoulas
added
the
pylint-tested
This was referenced Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
slots()won't now fail if it can't parse the mro object.I'm not sure that's the right way to fix that.
Type of Changes
Related Issue
#1088
Thanks!