Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from setuptools + setuptools_scm to hatchling + hatch-vcs #413

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 27, 2022

Changes proposed in this pull request:

@hugovk hugovk added the changelog: Changed For changes in existing functionality label Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #413 (dbbbcfe) into main (7f1de76) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files          12       12           
  Lines        2186     2186           
=======================================
  Hits         1969     1969           
  Misses        217      217           
Flag Coverage Δ
ubuntu-latest 90.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@djmattyg007
Copy link

I’m curious what you found appealing about hatchling that made it worth using over something more well known like poetry.

@djmattyg007
Copy link

Does renovatebot support hatchling?

@hugovk
Copy link
Member Author

hugovk commented Sep 30, 2022

I’m curious what you found appealing about hatchling that made it worth using over something more well known like poetry.

Well first of all, I'd like to move away from setuptools which is getting a bit old (or "setuptools is a hot mess of legacy code" :). It is being modernised, but there may be some disruption in the process (e.g. pypa/setuptools#3532).

Hatchling is standards compliant, and specifically built based on the new packaging standards for build backends (PEP 517/PEP 660) and the format for metadata declaration (PEP 621/PEP 631).

Also I haven't used Poetry much, so it doesn't gain much familiarity points.

And I've seen a lot of interest and other projects moving over, here's a few: https://hatch.pypa.io/latest/users/ (It's also the default option in this PyPA tutorial https://packaging.python.org/en/latest/tutorials/packaging-projects/.)

Does renovatebot support hatchling?

No, renovatebot doesn't support PEP 621 / hatchling: renovatebot/renovate#10187 But it doesn't matter as we're not pinning any dependencies there (as libraries shouldn't). We're only using it for GitHub Actions.

@ofek
Copy link

ofek commented Oct 24, 2022

Any update on this?

@hugovk
Copy link
Member Author

hugovk commented Oct 24, 2022

@djmattyg007 Do you have any further questions or concerns?

@djmattyg007
Copy link

Nope. I was just curious.

@hugovk
Copy link
Member Author

hugovk commented Oct 25, 2022

Good stuff, let's get this merged! 🚀

@hugovk hugovk merged commit 8ea5b42 into main Oct 25, 2022
@hugovk hugovk deleted the migrate-packaging branch October 25, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Changed For changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants