Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format and refactor #64

Merged
merged 6 commits into from
Feb 8, 2022
Merged

Format and refactor #64

merged 6 commits into from
Feb 8, 2022

Conversation

irina-baeva
Copy link
Contributor

  • set up Eslint and Prettier;
  • format and fix errors;

There is one problem left. When there is any eslint error, it is immediately showing an error screen in the browser "Compiled with errors", which could be closed, but it is annoying and should not happen. I will read more through some SO and Github threads like this facebook/create-react-app#10021

#59

Copy link
Contributor

@filias filias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thank you for all this work 👏

@irina-baeva irina-baeva merged commit 2a4b37c into master Feb 8, 2022
@irina-baeva irina-baeva deleted the format-and-refactor branch February 8, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants