Fix issue: 405 - improve cubing methods #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloCorcho
added
the
cubing
|
This branch is based on the one that includes the DataMask. Once that PR is merged, the only modified file will be cubing.py |
added 7 commits
May 10, 2024 16:02
|
This is ready for review and merging! |
paranoya
reviewed
May 28, 2024
| ) | ||
| return in_rectangle | ||
|
|
||
| def pixel_in_circle(pixel_pos, pixel_size, circle_pos, circle_radius): |
There was a problem hiding this comment.
Looks OK, but aren't we reinventing photutils?
This was referenced May 28, 2024
Closed
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a new cubing method that incorporates a pixel-rejection step.