Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tail method to check output files & transparent support for compressed jobs #894

Closed
wants to merge 23 commits into from

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Nov 10, 2022

With this you can do, e.g.

job.tail('error.out', lines=50)
...

This and job['error.out'] also work when the job is compressed.

@pmrv pmrv added the enhancement New feature or request label Nov 10, 2022
@ligerzero-ai ligerzero-ai added the format_black reformat the code using the black standard label Nov 21, 2022
@jan-janssen
Copy link
Member

To accelerate the backwards reading, there is some work from the pymatgen developers in their monty package:
https://pythonhosted.org/monty/_modules/monty/io.html#reverse_readline

@pmrv
Copy link
Contributor Author

pmrv commented Nov 22, 2022

I'm not opposed to using monty as such, but for a single function it may be a bit much to pull in a full dependency. As I expect people to use this for the (smaller) log files mostly anyway, I would keep it this way until someone complains they ran out of memory.

@pmrv pmrv added format_black reformat the code using the black standard and removed format_black reformat the code using the black standard labels Nov 22, 2022
@pmrv pmrv added the integration Start the integration tests with pyiron_atomistics/contrib for this PR label Nov 22, 2022
@jan-janssen
Copy link
Member

I'm not opposed to using monty as such, but for a single function it may be a bit much to pull in a full dependency.

As we have pymatgen as dependency for pyiron_atomistics which itself depends on monty I think having monty as dependency for pyiron_base is not too much of an overhead.

@pmrv
Copy link
Contributor Author

pmrv commented Nov 22, 2022

Ah, fair. I didn't know we already have it.

@pmrv pmrv added format_black reformat the code using the black standard and removed format_black reformat the code using the black standard labels Dec 7, 2022
Copy link
Contributor

@ligerzero-ai ligerzero-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out to me.

@stale
Copy link

stale bot commented Dec 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 31, 2022
Also use a sub test for every line test
@stale stale bot removed the stale label Jan 10, 2023
@stale
Copy link

stale bot commented Feb 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 2, 2023
@pmrv
Copy link
Contributor Author

pmrv commented Feb 2, 2023

The failure on windows is due to a bug in monty. I have opened an issue with them and added a small workaround+comment so this doesn't have to wait on their fix.

@pmrv pmrv removed the stale label Feb 2, 2023
@stale
Copy link

stale bot commented Feb 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 18, 2023
@stale stale bot closed this Mar 18, 2023
@pmrv pmrv reopened this Apr 25, 2023
@stale stale bot removed the stale label Apr 25, 2023
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 21, 2023
@stale stale bot closed this Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request format_black reformat the code using the black standard integration Start the integration tests with pyiron_atomistics/contrib for this PR stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants