hook: win32ctypes.core: always collect the ctypes backend #8544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always collect the `ctypes` backend (`win32ctypes.core.ctypes` modules), even if we are also collecting the `cffi` backend due to `cffi` being available in the build environment. This prevents issues when import of `cffi` is blocked at run-time (similarly to how we do it to avoid issues with -OO optimization level) or when `cffi` is excluded from collection by user (for example, by using `--exclude-module cffi`).
bwoodsend
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always collect the
ctypesbackend (win32ctypes.core.ctypesmodules), even if we are also collecting thecffibackend due tocffibeing available in the build environment.This prevents issues when import of
cffiis blocked at run-time (similarly to how we do it to avoid issues with -OO optimization level) or whencffiis excluded from collection by user (for example, by using--exclude-module cffi).Closes #8543.