[RFC] Use lief library and stop depending on binutils #5996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokm
reviewed
Jul 13, 2021
| @@ -68,7 +68,7 @@ jobs: | |||
| pip install --progress-bar=off -U -r tests/requirements-tools.txt -r tests/requirements-libraries.txt | |||
| # Compile bootloader | |||
| cd bootloader | |||
| python waf all | |||
| python waf all CFLAGS="-fcf-protection=none" | |||
There was a problem hiding this comment.
Does control-flow transfer instrumentation interfere with executable modification made via lief?
There was a problem hiding this comment.
|
This looks quite nice... |
|
My only cause for squeamishness is Alpine. I have now managed to build a wheel for it after running: first and waiting a couple of hours. A really organized company could feasibly build the wheel once then host it on a private PyPI instance with the restrictions on non-glibc wheels removed. This will hopefully go away once PEP656 happens. It also adds a runtime dependency on libstdc++ which isn't the end of the world but it's still a breaking change. |
|
I think this is the reason why it takes so long to build lief (defaults to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.