loader: move ctypes hooks into a module #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test attempts to trigger an error in PyInstaller's ctypes.CDLL() wrapper, by using sys and os as string variables in the global namespace.
Move the ctypes hooks from bootstrap script into separate module (pymod04_ctypes). The main motivation for this is to prevent the modifications to global namespace from affecting the ctypes hooks code. Specifically, if user decides to use `sys` or `os` as variables in the global namespace, that should not effect the ctypes hook function _frozen_name(), which treats `sys` and `os` as names of modules (which were bound to those names when the bootstrap script was executed). Fixes pyinstaller#5797. This commit is a cleaned-up and modernized version of corresponding commit from pyinstaller#3038 (daf60a6). Co-authored-by: Hartmut Goebel <h.goebel@crazy-compilers.com>
rokm
force-pushed
the
bootstrap-ctypes-as-module
branch
from
5a7dff9
to
be75a73
Compare
bwoodsend
reviewed
May 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
ctypeshooks from bootstrap script into separate module (pymod04_ctypes). The main motivation for this is to prevent the modifications to global namespace from affecting thectypeshooks code; specifically, if user decides to usesysorosas variables in the global namespace, that should not effect thectypeshook function_frozen_name(), which treatssysandosas names of modules (which were bound to those names when the bootstrap script was executed).Fixes #5797.
This commit is a cleaned-up and modernized version of selected commits from #3038, plus additional test that re-creates situation from #5797.