switch to modulegraph 2 #5808
Draft
switch to modulegraph 2 #5808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests for names available as public symbols in the modulegraph2 namespace. This also removes all incomplete and untested symbols from the public API (will be added back when I'm happy about the implementation)
Including full tests. The code doesn't use ast.NodeVisitor to avoid running out of stack space.
The tests have 100% test coverage according to coverage.py, but I haven't checked yet if there is sufficent testing.
One thing I don't quite like is a spurious return statement that's needed to keep coverage.py happy.
I'm not happy about the naming in modulegraph._depproc, and the global function '_process_namelist' (this should be a method given its close interaction with ModuleGraph)
There's still a test failure in a test method that was hidden by a test with the same name, I haven't investigated yet what's going on here.
…into modulegraph2
…into modulegraph2
…into modulegraph2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a draft PR to see what it would take to switch to modulegraph2
tracking #5812