depend: work around the potential None referer in get_co_using_ctypes #5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `ctypes` is (manually) added to hidden imports under python 3.7, one of `referers` entries processed in `get_co_using_ctypes()` method of `PyiModuleGraph` ends up being None. This in turn causes error when its `identifier` property is accessed, causing pyinstaller#3825. Work around the problem by explicitly skipping `None` entries. Fixes pyinstaller#3825.
bwoodsend
added
the
merge-on-ci-pass
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
ctypesis (manually) added to hidden imports under python 3.7, one ofreferersentries processed inget_co_using_ctypes()method ofPyiModuleGraphends up being None. This in turn causes error when itsidentifierproperty is accessed, causing #3825.Work around the problem by explicitly skipping
Noneentries.Fixes #3825.