Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent MERGE from creating self-references for duplicated TOC entries #5652

Merged
merged 1 commit into from Mar 27, 2021
Merged

Prevent MERGE from creating self-references for duplicated TOC entries #5652

merged 1 commit into from Mar 27, 2021

Commits on Mar 19, 2021

  1. building: prevent MERGE from creating self-references for duplicated … 

    …TOC entries

A duplicated TOC entry (e.g., a resource being once listed as binary
in Analysis.binaries and once as data in Analysis.datas) in the
first Analysis being passed to MERGE() ends up generating
a spurious DEPENDENCY entry with a self-reference to itself.

Therefore, the dependencies TOC of the primary Analysis object ends
up non-empty, and if passed to EXE(), results in a non-functional
executable.
    @rokm
    rokm committed Mar 19, 2021
    Copy the full SHA
    0aa65ff View commit details
    Browse the repository at this point in the history