compat: fix forced arch for helper-spawned python processes on macOS #5642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the architecture setting in __wrap_python() on macOS to handle arm64. Fixes helper-spawned python sub-processes failing to start with "Bad CPU type in executable" when running under arm64-only version of Python on Apple M1.
|
I was originally planning to put this into |
bwoodsend
approved these changes
Mar 17, 2021
|
✅ Build pyinstaller 1.0.972 completed (commit dd3f92ede5 by @rokm) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the architecture setting in
__wrap_python()on macOS to handlearm64. Fixes helper-spawned python sub-processes failing to start withBad CPU type in executablewhen running underarm64-only version of Python on Apple M1.Fixes #5640.