Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archive_viewer: implement full front-to-back file scan & fix crash on exit #5554

Merged
merged 2 commits into from Feb 20, 2021
Merged

archive_viewer: implement full front-to-back file scan & fix crash on exit #5554

merged 2 commits into from Feb 20, 2021

Commits on Feb 18, 2021

  1. archive: CArchiveReader: implement full back-to-front file search for… 

    … MAGIC

Allow archive-viewer to open binaries with more than 4096 bytes
of additional data past the appended package (e.g., macOS binaries
with code signature).
    @rokm
    rokm committed Feb 18, 2021
    Copy the full SHA
    289628a View commit details
    Browse the repository at this point in the history

  2. cliutils: archive_viewer: fix crash when quitting or moving up a level 

    Calling arch.lib.close() when cleaning up the archive when either
moving up a level or quitting the archive_viewer application
triggers the assert in pyimod02_archive.ArchiveFile.__getattr__.

This is because local file object is set only between __enter__
and __exit__ calls, i.e., while in the `with arch.lib:` block.
Which also means that there's no need for attempting to close
those file handles in the first place, and the error is probably
a regression from when the thread-local file objects were
introduced.
    @rokm
    rokm committed Feb 18, 2021
    Copy the full SHA
    81ecf66 View commit details
    Browse the repository at this point in the history