Ignore non-matching ldconfig
lines without blowing up
#5549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am running on Linux, with
ldconfig --version
:ldconfig -p
, which is run to locate shared object files during the build process, adds a couple extra lines that aren't libraries. I could not find a CLI arg to make it not print these.These were causing the build to blow up with the following error:
This PR makes
pyinstaller
ignoreldconfig
output lines that don't match the regex that parses out the library paths. I also added a log line to make it obvious when this is doing something unexpected (for example, this will make it obvious if thefixme
comment about library names containing whitespace needs to be addressed).