Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootloader: return 1 if frozen python script exits due to exception #5481

Merged
merged 1 commit into from Jan 27, 2021

Conversation

rokm
Copy link
Member

@rokm rokm commented Jan 17, 2021

Keep the bootloader's return code consistent with that of python interpreter, which returns 1 if it exits due to exception in the python script.

Fixes #5480.

Keep the bootloader's return code consistent with that of python
interpreter, which returns 1 if it exits due to exception in the
python script.

Fixes pyinstaller#5480.
Copy link
Member

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was scarily quick.

@rokm rokm marked this pull request as ready for review January 18, 2021 11:32
@Legorooj Legorooj merged commit cf9dfec into pyinstaller:develop Jan 27, 2021
@Legorooj Legorooj added the bugfix Only apply to pull-requests! label Jan 27, 2021
@rokm rokm deleted the unhandled-exception-retcode branch January 28, 2021 17:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Only apply to pull-requests!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows incorrect process status code (4294967295)
3 participants