loader: disable import tracing if sys.stderr is unavailable #5477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `FrozenImporter` in `pymod03_importers` uses `trace()` function if `sys.flags.verbose` is enabled to trace the imports to `sys.stderr`. This results in the following error: `Failed to execute script pyiboot01_bootstrap` when `sys.stderr` is unavailable (is `None`), which happens on Windows when windowed bootloader is used in combination with `sys.flags.verbose` enabled (i.e., `--debug imports` or `--debug all` is passed on the command-line). The problem is that while `pyiboot01_bootstrap` does install its `NullWriter` for `sys.stderr` when the latter is unavailable, that happens too late; there is an `import os` that happens between the end of bootstrap process (the `pyimod03_importers.install()` call) and monkey-patching `NullWriter()` into `sys.stderr`. While the problem could also be fixed by moving the `NullWriter` initialization before the offending import, simply disabling the `trace()` function seems a better option. Fixes pyinstaller#4213.
bwoodsend
approved these changes
Jan 24, 2021
Legorooj
approved these changes
Jan 28, 2021
|
Thank you so much! This fix saved me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FrozenImporterinpymod03_importersusestrace()function ifsys.flags.verboseis enabled to trace the imports tosys.stderr. This results in the following error:Failed to execute script pyiboot01_bootstrapwhen
sys.stderris unavailable (isNone), which happens on Windows when windowed bootloader is used in combination withsys.flags.verboseenabled (i.e.,--debug importsor--debug allis passed on the command-line).The problem is that while
pyiboot01_bootstrapdoes install itsNullWriterforsys.stderrwhen the latter is unavailable, thathappens too late; there is an
import osthat happens between the end of bootstrap process (thepyimod03_importers.install()call) and monkey-patchingNullWriter()intosys.stderr.While the problem could also be fixed by moving the
NullWriterinitialization before the offending import, simply disabling thetrace()function seems a better option.Fixes #4213.