Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building: Support arbitrarily large files in onefile mode. #4640

Closed
wants to merge 2 commits into from

Conversation

Chrisg2000
Copy link
Contributor

Previously, the maximum file size in CArchive was 2 GB, otherwise
the size value could not be stored. This was also not very
beneficial, because the bootloader allocates the size of the file
in memory during unpacking, which is a huge amount of data at once.
Now files larger than 512 MiB are divided into several archive entries
and thus unpacked to one file in several steps.

fixes #3939

This has the advantage that hints on the processing
of the data can be given.
Previously, the maximum file size in CArchive was 2 GB, otherwise
the size value could not be stored. This was also not very
beneficial, because the bootloader allocates the size of the file
in memory during unpacking, which is a huge amount of data at once.
Now files larger than 512 MiB are divided into several archive entries
and thus unpacked to one file in several steps.
@Chrisg2000
Copy link
Contributor Author

Chrisg2000 commented Jan 20, 2020

The attempt was a bit hasty: If files become larger than 2GB, the offset in the TOC becomes larger than 2147483647, which again leads to the error.

@Chrisg2000 Chrisg2000 closed this Jan 20, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error for binaries larger than 2Gb
1 participant