Prevent MERGE from creating self-references for duplicated TOC entries #5652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokm
force-pushed
the
multipackage-toc-duplicates
branch
from
e2147f9
to
a9250e4
Compare
|
Fixes a problem with |
…TOC entries A duplicated TOC entry (e.g., a resource being once listed as binary in Analysis.binaries and once as data in Analysis.datas) in the first Analysis being passed to MERGE() ends up generating a spurious DEPENDENCY entry with a self-reference to itself. Therefore, the dependencies TOC of the primary Analysis object ends up non-empty, and if passed to EXE(), results in a non-functional executable.
rokm
force-pushed
the
multipackage-toc-duplicates
branch
from
a9250e4
to
0aa65ff
Compare
rokm
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicated TOC entry (e.g., a resource being once listed as binary in
Analysis.binariesand once as data inAnalysis.datas) in the firstAnalysisbeing passed toMERGE()ends up generating a spuriousDEPENDENCYentry with a self-reference to itself.Therefore, the
dependenciesTOC of the primaryAnalysisobject ends up non-empty, and if passed toEXE(), results in a non-functional executable.