archive_viewer: implement full front-to-back file scan & fix crash on exit #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokm
force-pushed
the
archive-viewer-fullscan
branch
from
1332f2f
to
c4c2d74
Compare
rokm
changed the title
BoboTiG
approved these changes
Feb 13, 2021
… MAGIC Allow archive-viewer to open binaries with more than 4096 bytes of additional data past the appended package (e.g., macOS binaries with code signature).
Calling arch.lib.close() when cleaning up the archive when either moving up a level or quitting the archive_viewer application triggers the assert in pyimod02_archive.ArchiveFile.__getattr__. This is because local file object is set only between __enter__ and __exit__ calls, i.e., while in the `with arch.lib:` block. Which also means that there's no need for attempting to close those file handles in the first place, and the error is probably a regression from when the thread-local file objects were introduced.
rokm
force-pushed
the
archive-viewer-fullscan
branch
from
c4c2d74
to
81ecf66
Compare
|
Fixed a problem that one of the Windows CI pipelines tripped on; instead of trying to parse the whole cookie from last search buffer, we now need to explicitly read the whole cookie data into buffer before trying to parse it (as the search buffer may not contain the whole cookie). |
bwoodsend
approved these changes
Feb 20, 2021
Legorooj
approved these changes
Feb 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement full back-to-front file scan for the
MAGICpattern in theCArchivereader, as per discussion in #2372. This allowsarchive_viewerto find embedded package in binaries with additional appended data (e.g., digital signature). This also synchronizes the pattern search behavior in python-sideCArchiveimplementation with bootloader-side changes proposed in #5511.Fixes #2372.
The second commit fixes an assertion-related crash in
archive_viewerthat was uncovered during testing, and occurs when quitting the application or moving up a level.