building: ensure that onefile builds on Windows have manifest embedded

The onefile builds on Windows may not have manifest embedded if icon was explicitly disabled via `--icon NONE`. This in turn causes subtle issues, such as #5624.
pyinstaller · Mar 11, 2021 · dad3a21 · dad3a21
1 parent b9e70f3
commit dad3a21
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/PyInstaller/building/api.py b/PyInstaller/building/api.py
@@ -532,7 +532,8 @@ def assemble(self):
             raise SystemExit(_MISSING_BOOTLOADER_ERRORMSG)
 
         if is_win and (self.icon != "NONE" or self.versrsrc or self.resources
-                       or self.uac_admin or self.uac_uiaccess or not is_64bits):
+                       or self.uac_admin or self.uac_uiaccess or not is_64bits
+                       or (self.manifest and not self.exclude_binaries)):
             fd, tmpnm = tempfile.mkstemp(prefix=os.path.basename(exe) + ".",
                                          dir=CONF['workpath'])
             # need to close the file, otherwise copying resources will fail

diff --git a/news/5625.bugfix.rst b/news/5625.bugfix.rst
@@ -0,0 +1,2 @@
+(Windows) Fix ``onefile`` builds not having manifest embedded when icon is 
+disabled via ``--icon NONE``.