conf: Change default cache directory on Windows. (#5537)

The default cache directory should not be in the Roaming profile
(%APPDATA%) but much rather in the Local profile (%LOCALAPPDATA%)
since there is no need to synchronize it between computers.

PyInstaller/configure.py

@@ -65,7 +65,7 @@ def _get_pyinst_cache_dir():
     if compat.getenv('PYINSTALLER_CONFIG_DIR'):
         cache_dir = compat.getenv('PYINSTALLER_CONFIG_DIR')
     elif is_win:
-        cache_dir = compat.getenv('APPDATA')
+        cache_dir = compat.getenv('LOCALAPPDATA')
         if not cache_dir:
             cache_dir = os.path.expanduser('~\\Application Data')
     elif is_darwin:

news/5537.bugfix.rst

@@ -0,0 +1,6 @@
+(Windows) Change default cache directory to ``LOCALAPPDATA``
+(from the original ``APPDATA``).
+This is to make sure that cached data
+doesn't get synced with the roaming profile.
+For this and future versions ``AppData\Roaming\pyinstaller``
+might be safely deleted.