Skip to content

Commit

Permalink
building: ensure that onefile builds on Windows have manifest embedded (
Browse files Browse the repository at this point in the history
#5625)

* tests: add test for onefile builds on Windows having a manifest

Test building with different --icon options, as that is what seems to
be triggering inconsistent behavior at the moment.

* building: ensure that onefile builds on Windows have manifest embedded

The onefile builds on Windows may not have manifest embedded if
icon was explicitly disabled via `--icon NONE`. This in turn causes
subtle issues, such as #5624.

Remove the convoluted check for entering the resource-modification
codepath, as we always need to reach the part that embeds the
manifest in the onefile executable, and the rest of
resource-modification parts are already guarded by their corresponding
checks. This should simplify the code and make it less prone to
errors.
  • Loading branch information
rokm committed Mar 13, 2021
1 parent 197e3a0 commit 482b8a4
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 482b8a4

Please sign in to comment.