Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hooks: add hook for branca #318

Merged
merged 2 commits into from Sep 10, 2021
Merged

hooks: add hook for branca #318

merged 2 commits into from Sep 10, 2021

Conversation

eric15342335
Copy link
Contributor

No description provided.

@eric15342335 eric15342335 requested review from a team and Legorooj and removed request for a team September 10, 2021 08:27
@eric15342335 eric15342335 requested review from bwoodsend and removed request for Legorooj September 10, 2021 08:35
@eric15342335
Copy link
Contributor Author

Wait. The pull request already exists. Pointing to #61
I am closing this.

@rokm
Copy link
Member

rokm commented Sep 10, 2021

I think at this point, it's better if we merge this one and close the other one.

@eric15342335 eric15342335 reopened this Sep 10, 2021
@eric15342335
Copy link
Contributor Author

I think at this point, it's better if we merge this one and close the other one.

Consider merging the folium hook too.

@rokm
Copy link
Member

rokm commented Sep 10, 2021 •
edited

Consider merging the folium hook too.

Will do. I think folium depends on branca, so we need this hook merged first, anyway.

bwoodsend
bwoodsend approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I see you've done CI too.

@bwoodsend bwoodsend merged commit bf4c4d7 into pyinstaller:master Sep 10, 2021
@rokm rokm mentioned this pull request Sep 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokm rokm rokm approved these changes

@bwoodsend bwoodsend bwoodsend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric15342335 @rokm @bwoodsend