Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump github.com/imdario/mergo from 0.3.9 to 0.3.10" #242

Merged
merged 1 commit into from Jul 29, 2020
Merged

Revert "Bump github.com/imdario/mergo from 0.3.9 to 0.3.10" #242

merged 1 commit into from Jul 29, 2020

Conversation

fubarhouse
Copy link
Collaborator

@fubarhouse fubarhouse commented Jul 29, 2020 •
edited

Reverts #240

Looks like mergo is having trouble upstream...

panic: reflect: reflect.flag.mustBeAssignable using unaddressable value

goroutine 1 [running]:
reflect.flag.mustBeAssignableSlow(0x99)
        /usr/lib/go/src/reflect/value.go:247 +0x138
reflect.flag.mustBeAssignable(...)
        /usr/lib/go/src/reflect/value.go:234
reflect.Value.Set(0x9e0280, 0xf9f198, 0x99, 0x9e0280, 0xf9f198, 0x99)
        /usr/lib/go/src/reflect/value.go:1533 +0x3b
github.com/imdario/mergo.deepMerge(0x9e0280, 0xf9f198, 0x99, 0x9e0280, 0xf9f198, 0x99, 0xc000927aa0, 0x3, 0xc00040a4c0, 0x0, ...)
        /home/karl/go/pkg/mod/github.com/imdario/mergo@v0.3.10/merge.go:99 +0x32f7
github.com/imdario/mergo.deepMerge(0x9fbe60, 0xc0004f90b8, 0x195, 0x9fbe60, 0xc0004f8b38, 0x195, 0xc000927aa0, 0x2, 0xc00040a4c0, 0x0, ...)
        /home/karl/go/pkg/mod/github.com/imdario/mergo@v0.3.10/merge.go:147 +0xa85
github.com/imdario/mergo.deepMerge(0xa7e540, 0xc0004f9080, 0x199, 0xa7e540, 0xc0004f8b00, 0x199, 0xc000927aa0, 0x1, 0xc00040a4c0, 0x0, ...)
        /home/karl/go/pkg/mod/github.com/imdario/mergo@v0.3.10/merge.go:93 +0x31ed
github.com/imdario/mergo.deepMerge(0xa2f060, 0xc0004f9080, 0x199, 0xa2f060, 0xc0004f8b00, 0x199, 0xc000927aa0, 0x0, 0xc00040a4c0, 0x199, ...)
        /home/karl/go/pkg/mod/github.com/imdario/mergo@v0.3.10/merge.go:93 +0x31ed
github.com/imdario/mergo.merge(0xa56060, 0xc0004f9080, 0xa56060, 0xc0004f8b00, 0xc000927bd0, 0x1, 0x1, 0x5, 0xc000425930)
        /home/karl/go/pkg/mod/github.com/imdario/mergo@v0.3.10/merge.go:366 +0x32a
github.com/imdario/mergo.Merge(...)
        /home/karl/go/pkg/mod/github.com/imdario/mergo@v0.3.10/merge.go:296
github.com/fubarhouse/pygmy-go/service/library.mergeService(0x0, 0x0, 0x0, 0x0, 0xa8dc96, 0x1, 0x0, 0xc000390a20, 0x0, 0xc0000cf340, ...)
        /home/karl/go/src/github.com/fubarhouse/pygmy-go/service/library/library.go:39 +0xbf
github.com/fubarhouse/pygmy-go/service/library.getService(...)
        /home/karl/go/src/github.com/fubarhouse/pygmy-go/service/library/library.go:47
github.com/fubarhouse/pygmy-go/service/library.ImportDefaults(0xc00014e150, 0xa93313, 0x10, 0x0, 0x0, 0x0, 0x0, 0xa8dc96, 0x1, 0x0, ...)
        /home/karl/go/src/github.com/fubarhouse/pygmy-go/service/library/setup.go:36 +0x307
github.com/fubarhouse/pygmy-go/service/library.Setup(0xc00014e150)
        /home/karl/go/src/github.com/fubarhouse/pygmy-go/service/library/setup.go:129 +0x19f9
github.com/fubarhouse/pygmy-go/service/library.SshKeyAdd(0xc000291ee0, 0x1, 0x1, 0xc0002f8d50, 0xc0003a8ae0, 0x6, 0x6, 0xc00051a1b0, 0x1, 0xc0002e4730, ...)
        /home/karl/go/src/github.com/fubarhouse/pygmy-go/service/library/sshkeyadd.go:17 +0xa5
github.com/fubarhouse/pygmy-go/service/library.Up(0xc000291ee0, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /home/karl/go/src/github.com/fubarhouse/pygmy-go/service/library/up.go:133 +0xc7e
github.com/fubarhouse/pygmy-go/cmd.glob..func8(0xf6ab80, 0xf9f198, 0x0, 0x0)
        /home/karl/go/src/github.com/fubarhouse/pygmy-go/cmd/up.go:62 +0x137
github.com/spf13/cobra.(*Command).execute(0xf6ab80, 0xf9f198, 0x0, 0x0, 0xf6ab80, 0xf9f198)
        /home/karl/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:846 +0x29d
github.com/spf13/cobra.(*Command).ExecuteC(0xf6a640, 0x443c6a, 0xf2ede0, 0xc000000180)
        /home/karl/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950 +0x349
github.com/spf13/cobra.(*Command).Execute(...)
        /home/karl/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887
github.com/fubarhouse/pygmy-go/cmd.Execute()
        /home/karl/go/src/github.com/fubarhouse/pygmy-go/cmd/root.go:55 +0x31
main.main()
        /home/karl/go/src/github.com/fubarhouse/pygmy-go/main.go:26 +0x20

Reverting the change fixes this problem while I tend to it later.

@fubarhouse fubarhouse added bug Something isn't working priority:high labels Jul 29, 2020
@fubarhouse fubarhouse merged commit 2860c3f into master Jul 29, 2020
@fubarhouse
Copy link
Collaborator Author

Being investigated upstream, so the fix will be deferred to the next release.
darccio/mergo#90

@fubarhouse fubarhouse mentioned this pull request Aug 8, 2020
Closed
fubarhouse added a commit that referenced this pull request Aug 19, 2020
@fubarhouse
Revert "Bump github.com/imdario/mergo from 0.3.9 to 0.3.10 (#240)" (#242
bb342c0 
)

This reverts commit c4ff1d3.
fubarhouse added a commit that referenced this pull request Aug 19, 2020
@fubarhouse @dependabot-preview
#232: Update all restart policies to 'unless-stopped' (#250)
01a5e1a 
* #232: Update all restart policies to 'unless-stopped'

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* #233: Lando test (#234)

* Add a lando test
* Remove lando init from test
* update directory path change
* Update URL for lando project
* Lando uses slightly different Lagoon headers...

* Additional running check for container state searches. (#237)

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* Refactoring the `model` package (#239)

* Moar tests.
* Separate out Docker functions from the model package
* gofmt
* gofmt
* remove key operation examples for now
* Forgot to actually start the containers.
* Additional running check for container state searches. (#237)
* add dist to gitignore
* Update output path
* Decouple regression tests from using docker client api directly and use docker lib
* Add some notes on local development
* add service tests into travis

* Bump github.com/imdario/mergo from 0.3.9 to 0.3.10 (#240)

Bumps [github.com/imdario/mergo](https://github.com/imdario/mergo) from 0.3.9 to 0.3.10.
- [Release notes](https://github.com/imdario/mergo/releases)
- [Commits](darccio/mergo@v0.3.9...v0.3.10)

* Revert "Bump github.com/imdario/mergo from 0.3.9 to 0.3.10 (#240)" (#242)

This reverts commit c4ff1d3.

* Update applicable references from master to main

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* Bump github.com/spf13/viper from 1.7.0 to 1.7.1 (#245)

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.7.0...v1.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* #246: Create new value for services before merging default values in place (#247)

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* #244: Stabilise Lando tests (#249)

* Try rebuilding Lando project before starting.
* add sleep command to alndo build process
* ignore lando start failures

* Bump github.com/imdario/mergo from 0.3.9 to 0.3.11 (#248)

Bumps [github.com/imdario/mergo](https://github.com/imdario/mergo) from 0.3.9 to 0.3.11.
- [Release notes](https://github.com/imdario/mergo/releases)
- [Commits](darccio/mergo@v0.3.9...v0.3.11)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Update tests for field values of restart policy to match new value "unless-stopped"

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
fubarhouse added a commit that referenced this pull request Aug 25, 2020
@fubarhouse
Revert "Bump github.com/imdario/mergo from 0.3.9 to 0.3.10 (#240)" (#242
9cca831 
)

This reverts commit c4ff1d3.
fubarhouse added a commit that referenced this pull request Aug 25, 2020
@fubarhouse @dependabot-preview
#232: Update all restart policies to 'unless-stopped' (#250)
a6881fe 
* #232: Update all restart policies to 'unless-stopped'

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* #233: Lando test (#234)

* Add a lando test
* Remove lando init from test
* update directory path change
* Update URL for lando project
* Lando uses slightly different Lagoon headers...

* Additional running check for container state searches. (#237)

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* Refactoring the `model` package (#239)

* Moar tests.
* Separate out Docker functions from the model package
* gofmt
* gofmt
* remove key operation examples for now
* Forgot to actually start the containers.
* Additional running check for container state searches. (#237)
* add dist to gitignore
* Update output path
* Decouple regression tests from using docker client api directly and use docker lib
* Add some notes on local development
* add service tests into travis

* Bump github.com/imdario/mergo from 0.3.9 to 0.3.10 (#240)

Bumps [github.com/imdario/mergo](https://github.com/imdario/mergo) from 0.3.9 to 0.3.10.
- [Release notes](https://github.com/imdario/mergo/releases)
- [Commits](darccio/mergo@v0.3.9...v0.3.10)

* Revert "Bump github.com/imdario/mergo from 0.3.9 to 0.3.10 (#240)" (#242)

This reverts commit c4ff1d3.

* Update applicable references from master to main

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* Bump github.com/spf13/viper from 1.7.0 to 1.7.1 (#245)

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.7.0...v1.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* #246: Create new value for services before merging default values in place (#247)

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* #244: Stabilise Lando tests (#249)

* Try rebuilding Lando project before starting.
* add sleep command to alndo build process
* ignore lando start failures

* Bump github.com/imdario/mergo from 0.3.9 to 0.3.11 (#248)

Bumps [github.com/imdario/mergo](https://github.com/imdario/mergo) from 0.3.9 to 0.3.11.
- [Release notes](https://github.com/imdario/mergo/releases)
- [Commits](darccio/mergo@v0.3.9...v0.3.11)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Update tests for field values of restart policy to match new value "unless-stopped"

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@fubarhouse fubarhouse deleted the revert-240-dependabot/go_modules/github.com/imdario/mergo-0.3.10 branch March 6, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working priority:high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fubarhouse