Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated pull request for "Adding Flex Lexer based on issue #1893" #2143

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

Updated pull request for "Adding Flex Lexer based on issue #1893" #2143

wants to merge 53 commits into from

Conversation

mattv52
Copy link

@mattv52 mattv52 commented May 23, 2022

No description provided.

mattv52 and others added 30 commits April 11, 2022 20:23
@mattv52
Added blank class for Flex
cd76f40
@erickhartawan
testLexer in c_like.py
ba5e107
@mattv52
Added FlexLexer empty class
714db3f
@mattv52
fixed merge from test commit
5264a62
@erickhartawan
added filenames and mimetypes
8e84e26
@erickhartawan
resolved conflic
d4f3abd
@mattv52
Added more description for FlexLexer
3223050
@erickhartawan
resolved conflict in Flex class description
27e2f66
@erickhartawan
added Function names and Builtin expressions
72a0090
@mattv52
Merge branch 'pygments:master' into master
4d9e086
@mattv52
Fixed some formatting. Commented out an error in 'statements'
fb7d63e
@mattv52
Added seperate state to handle rules section and added correctly toke…
f15f33f 
…ned special chars (i.e. \n, \r etc)
@erickhartawan
fixed error in statements and regex for [:alnum:] working
b8d090f
@erickhartawan
fixed typo in filenames and added more test in example.l
d6844ce
@mattv52
Merge branch 'pygments:master' into master
a02f7b7
@erickhartawan
updated rules to include root
8e82fc8
@erickhartawan
Merge branch 'master' of https://github.com/dman000/pygments
8e4573a
@mattv52
fixed not finding first %%
fece791
@mattv52
added handling for char ranges outside of '' in definitions
4a107c8
added two test files
60bd2d4
added alternative test with different extension
574044c
added basic tests and different extension test
6baafaa
@Hubert-Au
Merge pull request #1 from dman000/testingBranch
c976cff 
Testing branch
@erickhartawan
Seperated Built in Names and Functions. Added all existing names
c1711ad
@erickhartawan
Merge branch 'master' of https://github.com/dman000/pygments
6f342e2
fixed highlighting for multiple characters
0cdfc20
Merge pull request #2 from dman000/FixingHighlighting
a05af67 
fixed highlighting for multiple keywords
@TDinh989
special characters highlight /n /t /r
a8501e8
@Hubert-Au
Merge pull request #3 from dman000/Special_Characters
1ebd2f1 
special characters highlight /n /t /r
@TDinh989
changed Special Characters highlight to String.Escape
653ef9f
Thiem948 and others added 23 commits May 9, 2022 20:18
@Thiem948
Merge pull request #4 from dman000/Special_Characters
9c82834 
changed Special Characters highlight to String.Escape
@erickhartawan
Removed local testing files
0f1f927
@erickhartawan
removed duplicate statements from FlexLexer
47f916d
@mattv52
Removed testing files properly
f070436
@mattv52
Replaced new lines from comments
4053e48
@mattv52
Replaced new lines from comments
b373ceb
@mattv52
Changed link to modern site and added URL attribute
b41987a
@mattv52
Removed whitespace on newlines
a9263fd
@mattv52
Added a rough outline for the new format of lexer
81e884e
@erickhartawan
Working on restructuring FlexLexer
8424154
@mattv52
Implemented regex state and fixed some small thing with other states
57b8160
@erickhartawan
fixed definition section. to add C expression
28918b7
@erickhartawan
improved expression
189ac06
@erickhartawan
reverted the usercode section
88a91c8
@erickhartawan
removed extra header state and included whitespace
2f5364c
@mattv52
Fixed spacing and operator lex
091af27
@mattv52
Moved code from flex-Rules branch to this branch and compacted it down
2bfcaee
@mattv52
Added 'assign' state to handle how to lex the things variables are as…
5af7661 
…signed in the first section
@mattv52
made assign string use string state to more acurately lex the strings
d827e5c
@mattv52
Fixed incorrect highlighting of \t\n in rules
9aaae24
@mattv52
Chanegd some tokens and removed old commented out code
33a525c
@mattv52
removed some testing files
5c40e41
@mattv52
Merge branch 'pygments:master' into fix-PR
60b4363
@mattv52 mattv52 closed this May 23, 2022
@mattv52 mattv52 reopened this May 23, 2022
@mattv52 mattv52 changed the title Fix pr Updated pull request for "Adding Flex Lexer based on issue #1893" May 23, 2022
@Anteru
Copy link
Collaborator

Anteru commented Jul 26, 2022

This is missing the golden tests outputs which you can generate using pytest --update-goldens. That said, there are error tokens generated as it looks like the transition to the CLexer is not correct and the CLexer fails to classify some tokens. I didn't have time to investigate this further, but that'll be the next problem you'll run into once you try to create the golden test files. Sorry it took so long to get to this :/

@Anteru Anteru added the update needed Waiting for an update from the PR/issue creator label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
update needed Waiting for an update from the PR/issue creator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mattv52 @Anteru @erickhartawan @Hubert-Au @TDinh989 @Thiem948