Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL1 buildconfig removal #2824

Merged
merged 3 commits into from Nov 7, 2021
Merged

SDL1 buildconfig removal #2824

merged 3 commits into from Nov 7, 2021

Conversation

illume
Copy link
Member

@illume illume commented Nov 6, 2021

No description provided.

ankith26
ankith26 approved these changes Nov 7, 2021
View reviewed changes
Copy link
Contributor

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is good progress on the 2.1 cleanup! Dankesch枚n 馃憤 馃コ

@ankith26 ankith26 added this to the 2.1 milestone Nov 7, 2021
Starbuck5
Starbuck5 approved these changes Nov 7, 2021
View reviewed changes
Copy link
Contributor

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a good cleanup! I've been looking forward to a cleaner buildconfig.

I read over the changes and they all seemed good, I also tested my Windows workflow, and that still worked great.

@illume illume merged commit 71f593a into main Nov 7, 2021
@illume illume deleted the sdl1-removal2 branch November 7, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@illume @Starbuck5 @ankith26 @robertpfeiffer