Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mixer/music docs, unskip mp3 tests #2780

Merged
merged 1 commit into from Oct 23, 2021
Merged

update mixer/music docs, unskip mp3 tests #2780

merged 1 commit into from Oct 23, 2021

Conversation

ankith26
Copy link
Contributor

Minor PR, updates the docs to mention better MP3 support in latest pygame version, clarifies that pygame.mixer loads music at once (to close #2505) and also removes test skips on MP3 file loading

@ankith26 ankith26 added this to the 2.0.3 milestone Oct 19, 2021
Starbuck5
Starbuck5 approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good.

illume
illume approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illume illume merged commit b1d1978 into main Oct 23, 2021
@illume illume deleted the ankith26-mixer-doc branch October 23, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illume illume illume approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.

pygame.mixer.Sound - File loaded into memory
3 participants
@ankith26 @illume @Starbuck5