Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of cleanups #2779

Merged
merged 2 commits into from Oct 23, 2021
Merged

Lots of cleanups #2779

merged 2 commits into from Oct 23, 2021

Conversation

Starbuck5
Copy link
Contributor

I was looking at some of the files in /examples/data, and I thought it would be pretty easy to decrease the size of pygame wheels / installations with minimal effort

  • Reencoded turquoise.tiff to actually be compressed
  • Reencoded fist.bmp, chimp.bmp to pngs for filesize (Had to change references to these files in the tests, other examples, and even the tutorial for the chimp example)
  • Removed yuv_1.pgm, which was only used by the overlay example, so I removed that too (it's deprecated, no need to keep the example there)
  • Removed oldplayer.gif, which wasn't being used

This made me realize the mask example was broken by the size of "fist.bmp" being much bigger than it was in the past, so I told it to use chimp.png instead.

I also:

  • Changed the surface size error message because (w, h) don't need to be ints
  • Removed the overlay test (deprecated, and it was a placeholder test anyway)
  • Removed an old pygame.movie dummy backend file that was hanging around
  • Committed an automatic setup.py docs .h file change from the joysticks example existing

I didn't mean to touch so many files, but I think this is a straightforward cleanup of some loose ends. It also reduces the size of a pygame installation by a little more than a megabyte. 13.4 mb -> 12.2 mb on my system.

Copy link
Contributor

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 🥳

@ankith26 ankith26 added this to the 2.0.3 milestone Oct 19, 2021
Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice cleanups. Thanks.

@illume illume merged commit 9b2e137 into pygame:main Oct 23, 2021
@Starbuck5 Starbuck5 deleted the cleanups branch February 7, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants