config_darwin.py improvements #2768
Conversation
The actual code of frameworks shipped with the OS is no longer present as a file in the filesystem (it's only in the shared cache).
There was a problem hiding this comment.
Hi! Thanks for submitting a PR to pygame! 👍
I don't have a mac, so I can't test this locally. AFAIK, we don't actually use FrameworkDependency on our mac builds ATM. From the code, I see only sdl1 stuff using this (which we don't use now, and are planning to drop in a future version) and also some porttime/quicktime stuff, which I am not sure whether we are using these ATM.
But that is fine, this PR should still be good to go!
My only other concern is that does this change break compatibility with older mac versions which have the frameworks as files?
It doesn't; the enclosing directory will still be there on any OS version. |
It looks like the only reason direct use of CoreMIDI was added in e51ce10 was as a slightly odd workaround for the Dependency class's inability to handle a dependency on a header without a corresponding library. (porttime.h is installed by portmidi but there is no libporttime.) QUICKTIME doesn't appear to be used at all.
jmroot
changed the title
|
Updated to remove unnecessary framework dependencies, prompted by discussion in #2767. |
The actual code of frameworks shipped with the OS is no longer present as a file in the filesystem (it's only in the shared cache).