New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added doc for Cursor object #2709
Conversation
It is documented, it's just that the docs on the website haven't been updated since 2.0.0. If you generate the docs locally you'll be able to see it, or if you snoop around the It is a shame though, so I wrote a reddit post that will hopefully explain it to people before the docs get regenerated: https://www.reddit.com/r/pygame/comments/octscc/definitive_guide_to_pygame_cursors/. With that in mind, do we need docstrings in the source? Maybe the docstrings would should up on some editors, which could help people out? But they should probably be a close copy of what is in the documentation itself. |
Sure, but I noticed there was one init overload that was not documented, and I added it to the docstring inside the cursor object. It is not documented in the corresponding .rst file either sadly... |
The But if you want to document it you should change it in the documentation, not in a docstring. Also, your docstring misses an |
Oh thanks for noticing. Do you think I should document it too ? |
I also added a copy method in case someone wants to duplicate the cursor (even though I assume that would be very rare but still useful)
Matched the docstrings in cursors.py plus some extra info I noticed while reading the code
Ok so now I am finished |
Also, it would be good if you could build the docs locally, because that would forward your changes to It should just be |
Ok I will check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements to the Cursor docs, thanks.
These two things remain:
- generate .h files (run
python setup.py docs
) - fix
thoses
typo which should bethose
.
Let us know if you want us to finish these two things off? We can merge your branch in, and then fix them.
Which setup.py should I run ? The one from my fork or the original one ? |
(also I corrected the typo) |
I corrected the typo myself, can you generate the .h files please ? |
Cool, thanks. Will do. |
Thanks a lot |
The pygame.cursors.Cursor object is a brand new feature that I have just discovered, and I find sad that is is not documented already, so I tried to make a decent one