setup.py test is deprecated

[jamesmyatt]

See:

• setup.py test is going to be deprecated pytest-dev/pytest#5534
• https://github.com/pytest-dev/pytest-runner/blob/main/README.rst

Also updated some instructions to use python -m pytest ... as recommended by: https://docs.pytest.org/en/6.2.x/usage.html#calling-pytest-through-python-m-pytest

[codecov-commenter]

Codecov Report

Merging #3317 (e7fdf1d) into master (76c518b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3317   +/-   ##
=======================================
  Coverage   81.39%   81.39%           
=======================================
  Files         289      289           
  Lines       14210    14210           
=======================================
  Hits        11566    11566           
  Misses       2644     2644           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76c518b...e7fdf1d. Read the comment docs.

[rusty1s]

Thanks. I always wanted to fix this :)

[jamesmyatt]

Hi @rusty1s. Thanks for merging this. Looks like you've undone the changes to setup.py. Why is this?

Including setup_requires and test_requires in setup.py is now considered bad practice. Also including pytest-runner in the test extras also seems like a bad idea, since it's only purpose is the setuptools integration, so it will unnecessarily bloat your test environment. See https://github.com/pytest-dev/pytest-runner#deprecation-notice

[rusty1s]

Initially I thought that allowing testing via python setup.py test should still work. I reverted that change once again. Sorry for that :)

[jamesmyatt]

No problem. Just wanted to understand.