Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple versions for pyenv-install #2568

Merged
merged 1 commit into from Dec 22, 2022

Conversation

rockandska
Copy link
Contributor

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

As stated in #919, many of the users (as me) expect to have pyenv to install all versions specified in .python-version and have pyenv install works the same way as pyenv local works

Tests

  • My PR adds the following unit tests (if any)
    • install proper multi versions
    • install resolves a prefix with multi versions
    • install pyenv local multi versions by default
    • multi arguments for pyenv-install
  • My PR remove the following unit tests (if any)
    • too many arguments for pyenv-install
      • replaced by multi arguments for pyenv-install since user could specify multi versions now

@anton-petrov anton-petrov merged commit cb5da5e into pyenv:master Dec 22, 2022
@colindean
Copy link

Thank you!

@rockandska rockandska deleted the fix/919 branch December 28, 2022 00:22
@rockandska
Copy link
Contributor Author

Just seen that it was added too in actions/setup-python#567
Perfect timing ^^

@native-api native-api mentioned this pull request Jan 22, 2023
5 tasks
native-api added a commit that referenced this pull request Jan 22, 2023
* Cleanup mocks logic
* Add test for `:latest`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyenv install without args fails with multiple versions in .python-version
3 participants