-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing axis kwargs to plot #4020
Merged
Merged
Changes from 24 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
0d4d29a
fix facecolor plot
raphaeldussin 04a48c4
temp version
raphaeldussin 2577ddd
finish fix facecolor + solves #3169
raphaeldussin c5c7732
black formatting
raphaeldussin 9d259e2
add testing
raphaeldussin 2d7cf27
allow cartopy projection to be a kwarg
raphaeldussin 19b59a3
fix PEP8 comment
raphaeldussin d439f6b
black formatting
raphaeldussin 2d5b599
fix testing, plt not in parameterize
raphaeldussin 4d00aeb
fix testing, allows for no matplotlib
raphaeldussin 7c80566
Merge branch 'fix_facecolor_plot' of https://github.com/raphaeldussin…
raphaeldussin ba36f83
black formating
raphaeldussin f7c48be
fix tests without matplotlib
raphaeldussin 180d451
fix some mistakes
raphaeldussin e8abe18
isort, mypy
raphaeldussin 7c46b01
fix mypy
raphaeldussin 2739599
Merge remote-tracking branch 'xarray/master' into fix_facecolor_plot
raphaeldussin 5f30e7c
remove empty line
raphaeldussin aebb441
correction from review
raphaeldussin 38fbfde
correction from 2nd review
raphaeldussin 66e07df
updated tests
raphaeldussin 3a12e86
updated tests
raphaeldussin cdeea2f
Merge branch 'fix_facecolor_plot' of https://github.com/raphaeldussin…
raphaeldussin ee25c00
black formatting
raphaeldussin 7ae74fe
follow up correction from review
raphaeldussin a049209
fix tests
raphaeldussin 98264bd
fix tests again
raphaeldussin 79b08db
fix bug in tests
raphaeldussin f54d585
fix pb in tests
raphaeldussin 1cec6cd
remove useless line
raphaeldussin 073c64b
clean up tests
dcherian a652843
fix
dcherian d65416a
Add whats-new
dcherian b1c15ad
Merge remote-tracking branch 'upstream/master' into fix_facecolor_plot
dcherian File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future, these kinds of formatting issues in documentation can be automatically fixed using
blackdoc
, see #4177.