Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing axis kwargs to plot #4020

Merged
merged 34 commits into from Jul 2, 2020
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
0d4d29a
fix facecolor plot
raphaeldussin May 2, 2020
04a48c4
temp version
raphaeldussin May 15, 2020
2577ddd
finish fix facecolor + solves #3169
raphaeldussin May 16, 2020
c5c7732
black formatting
raphaeldussin May 16, 2020
9d259e2
add testing
raphaeldussin May 16, 2020
2d7cf27
allow cartopy projection to be a kwarg
raphaeldussin May 16, 2020
19b59a3
fix PEP8 comment
raphaeldussin May 16, 2020
d439f6b
black formatting
raphaeldussin May 16, 2020
2d5b599
fix testing, plt not in parameterize
raphaeldussin May 16, 2020
4d00aeb
fix testing, allows for no matplotlib
raphaeldussin May 16, 2020
7c80566
Merge branch 'fix_facecolor_plot' of https://github.com/raphaeldussin…
raphaeldussin May 16, 2020
ba36f83
black formating
raphaeldussin May 16, 2020
f7c48be
fix tests without matplotlib
raphaeldussin May 16, 2020
180d451
fix some mistakes
raphaeldussin May 16, 2020
e8abe18
isort, mypy
raphaeldussin May 16, 2020
7c46b01
fix mypy
raphaeldussin May 16, 2020
2739599
Merge remote-tracking branch 'xarray/master' into fix_facecolor_plot
raphaeldussin Jun 12, 2020
5f30e7c
remove empty line
raphaeldussin Jun 23, 2020
aebb441
correction from review
raphaeldussin Jun 23, 2020
38fbfde
correction from 2nd review
raphaeldussin Jun 24, 2020
66e07df
updated tests
raphaeldussin Jun 24, 2020
3a12e86
updated tests
raphaeldussin Jun 24, 2020
cdeea2f
Merge branch 'fix_facecolor_plot' of https://github.com/raphaeldussin…
raphaeldussin Jun 25, 2020
ee25c00
black formatting
raphaeldussin Jun 25, 2020
7ae74fe
follow up correction from review
raphaeldussin Jun 25, 2020
a049209
fix tests
raphaeldussin Jun 25, 2020
98264bd
fix tests again
raphaeldussin Jun 25, 2020
79b08db
fix bug in tests
raphaeldussin Jun 25, 2020
f54d585
fix pb in tests
raphaeldussin Jun 25, 2020
1cec6cd
remove useless line
raphaeldussin Jun 25, 2020
073c64b
clean up tests
dcherian Jun 29, 2020
a652843
fix
dcherian Jun 29, 2020
d65416a
Add whats-new
dcherian Jul 1, 2020
b1c15ad
Merge remote-tracking branch 'upstream/master' into fix_facecolor_plot
dcherian Jul 1, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions xarray/tests/test_plot.py
Expand Up @@ -28,6 +28,7 @@
requires_matplotlib,
requires_nc_time_axis,
requires_seaborn,
requires_cartopy,
)

# import mpl and change the backend before other mpl imports
Expand Down Expand Up @@ -2421,6 +2422,8 @@ def test_get_axis(figsize, aspect, size):

@requires_cartopy
def test_get_axis_cartopy():
import cartopy as ctpy

raphaeldussin marked this conversation as resolved.
Show resolved Hide resolved
kwargs = {"projection": ctpy.crs.PlateCarree()}
ax = get_axis(**kwargs)
assert isinstance(ax, ctpy.mpl.geoaxes.GeoAxesSubplot)