Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: make the icons available to implicit component #991

Merged
merged 3 commits into from Oct 12, 2022

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Oct 6, 2022

Fix #982

apparently the :root pseudo selector is not available to :before. We never realized this because all our colors are stored in html since the dark theme introduction.

@12rambau 12rambau marked this pull request as ready for review October 6, 2022 21:10
@12rambau
Copy link
Collaborator Author

12rambau commented Oct 7, 2022

anoher solution would be to replace the :root selector by htmleverywhere to avoid surprises (as we are using :before and :after a lot)

Looking on the web the :root is only useful if the css is used on multiple document including non-html (SVG, XML) which is not our case. In the context of pydata-sphinx-theme, :root is always html

@choldgraf
Copy link
Collaborator

I'm not really sure the implications between :root and :html but from your description, :html seems simpler and safe

@12rambau
Copy link
Collaborator Author

12rambau commented Oct 7, 2022

to make it simple, :root is useful if you use css for many file type as it will be replace by the first tag (html, div whatever). As we are building a theme for an html output (only) I think it's an overkill to use it and it leads to bugs of this type that are difficult to track down.

I replaced every occurences of :root by html everywhere (including documentation)

Note
custom.css that is using :root should still work as :root is html for the browser

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested out the "hide search highlights" button and it works well! Looks good to me.

@choldgraf choldgraf merged commit d99811d into pydata:main Oct 12, 2022
@12rambau 12rambau deleted the root branch October 12, 2022 09:39
@jarrodmillman jarrodmillman added this to the 0.12 milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing icon in hide search highlights button
3 participants