Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and add deprecation warnings for section names #988

Merged
merged 3 commits into from Oct 6, 2022

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Oct 6, 2022

rebase from #789 initialy proposed by @choldgraf:

This adds some renaming in the docs and checks for old configuration values since we are standardizing our naming of the primary/secondary sidebars.

@12rambau 12rambau changed the title Rename and add deprecation warnings to for section names Rename and add deprecation warnings for section names Oct 6, 2022
@12rambau 12rambau marked this pull request as ready for review October 6, 2022 17:28
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for picking this up 🙏

It looks good to me. IMO we should merge it relatively quickly because it's going to go out of date quickly as well

@drammock drammock merged commit 355fe0b into pydata:main Oct 6, 2022
@12rambau 12rambau deleted the primary branch October 6, 2022 17:54
@jarrodmillman jarrodmillman added this to the 0.12 milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants